Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor pyo3-ffi example to an example project #3487

Merged
merged 1 commit into from
Oct 9, 2023
Merged

refactor pyo3-ffi example to an example project #3487

merged 1 commit into from
Oct 9, 2023

Conversation

mejrs
Copy link
Member

@mejrs mejrs commented Oct 2, 2023

No description provided.

@mejrs mejrs added the CI-skip-changelog Skip checking changelog entry label Oct 2, 2023
davidhewitt
davidhewitt reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a good idea! I had a read and have a few small suggestions...

pyo3-ffi/README.md Outdated Show resolved Hide resolved
pyo3-ffi/README.md Outdated Show resolved Hide resolved
pyo3-ffi/README.md Outdated Show resolved Hide resolved
examples/string-sum/tests/test_.py Outdated Show resolved Hide resolved
examples/string-sum/src/lib.rs Outdated Show resolved Hide resolved
examples/string-sum/src/lib.rs Outdated Show resolved Hide resolved
davidhewitt
davidhewitt approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though looks like you need to format and update the expected test error messages. Maybe squash at the same time and feel free to merge after that :)

@mejrs
Copy link
Member Author

mejrs commented Oct 3, 2023

I HATE C'S INTEGER HIERARCHY

...but done 👍

@mejrs
Copy link
Member Author

mejrs commented Oct 3, 2023

@davidhewitt I did rework the exception handling, please merge if you approve 😄

davidhewitt
davidhewitt approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great, thanks again!

@davidhewitt davidhewitt added this pull request to the merge queue Oct 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2023
davidhewitt
davidhewitt reviewed Oct 4, 2023
View reviewed changes
examples/string-sum/src/lib.rs Outdated

let (first, second) = (*args, *args.add(1));

let Some(first) = parse_arg_as_i32(first, 1) else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah unfortunately let else is not stable on our MSRV!

@mejrs mejrs force-pushed the ffi_example branch 2 times, most recently from 1a2f596 to 9171221 Compare October 6, 2023 18:35
@mejrs mejrs enabled auto-merge October 6, 2023 18:48
@mejrs mejrs added this pull request to the merge queue Oct 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2023
@mejrs mejrs added this pull request to the merge queue Oct 9, 2023
Merged via the queue into PyO3:main with commit 300f2d6 Oct 9, 2023
@mejrs mejrs deleted the ffi_example branch October 9, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mejrs @davidhewitt